Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: remoting/webapp/build_template.gni

Issue 1152583011: Refactor compile_js.gypi to support script_args and closure_args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: app_remoting_webapp gyp stuff Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/build_template.gni
diff --git a/remoting/webapp/build_template.gni b/remoting/webapp/build_template.gni
index 9e8ab1804540bcfef23914a261eec9d28f885f96..752d141a6ad94520183628244f7baf131f98856a 100644
--- a/remoting/webapp/build_template.gni
+++ b/remoting/webapp/build_template.gni
@@ -9,6 +9,7 @@ import("//remoting/remoting_locales.gni")
import("//remoting/remoting_options.gni")
import("//remoting/remoting_version.gni")
import("//remoting/webapp/files.gni")
+import("//third_party/closure_compiler/closure_args.gni")
# The base remoting directory that is used as the root directory for file
# references. Many of the scripts rely on the files being specified relative
@@ -61,15 +62,22 @@ template("build_webapp_html") {
target_jscompile_stamp,
]
- args = [
- "--strict",
- "--no-single-file",
- "--externs",
- "../../third_party/closure_compiler/externs/chrome_extensions.js",
- "--success-stamp",
- rebase_path(target_jscompile_stamp, root_build_dir),
+ extra_closure_args = [
+ "jscomp_error=reportUnknownTypes",
+ "jscomp_error=duplicate",
+ "jscomp_error=misplacedTypeAnnotation",
]
- args += rebase_path(js_files, root_build_dir)
+
+ args = rebase_path(js_files, root_build_dir)
+ args +=
+ [
+ "--no-single-file",
+ "--externs",
+ "../../third_party/closure_compiler/externs/chrome_extensions.js",
+ "--out-file",
+ rebase_path(target_jscompile_stamp, root_build_dir),
+ "--closure-args",
+ ] + closure_args + extra_closure_args
}
}

Powered by Google App Engine
This is Rietveld 408576698