Refactor compile_js.gypi to support script_args and closure_args

remoting/app_remoting_webapp_compile.gypi

Index: remoting/app_remoting_webapp_compile.gypi
diff --git a/remoting/app_remoting_webapp_compile.gypi b/remoting/app_remoting_webapp_compile.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..4cc36d9f2aa02ccd1217cf5a28ff2379e3d4feb7
--- /dev/null
+++ b/remoting/app_remoting_webapp_compile.gypi
@@ -0,0 +1,45 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'includes': [
+      '../remoting/remoting_webapp_files.gypi',
+      '../remoting/app_remoting_webapp_files.gypi',
+   ],
+  'targets': [
+    {
+      'target_name': 'verify_main.html',

[Theresa, 2015/06/12 20:36:51]

Previously, the action name had  >(ar_app_name) in the middle. Including
app_remoting_webapp_build.gypi was causing cascading problems around app_name
not being defined, then app_description, then app_id, etc. I don't think any of
those variables actually need to be defined to compile JS.

Is it okay to drop the app_name form these target names or should I figure out a
way to get it in there?

[garykac, 2015/06/16 00:32:42]

It's OK to drop that. We had that because we were running jscompile after each
app was built and needed a different action name.

Having it depend on just the source files is fine.

[Theresa, 2015/06/16 17:49:45]

Acknowledged.

+      'variables': {
+        'source_files': [
+          '<@(ar_main_js_files)',
+          '<@(remoting_webapp_js_proto_files)',
+        ],
+        'out_file': '<(PRODUCT_DIR)/>(_target_name)_main_jscompile.stamp',
+      },
+       'includes': ['compile_js.gypi'],
+    },
+    {
+      'target_name': 'verify_background.js',
+      'variables': {
+        'source_files': [
+          '<@(ar_background_js_files)',
+          '<@(remoting_webapp_js_proto_files)',
+        ],
+        'out_file': '<(PRODUCT_DIR)/>(_target_name)_background_jscompile.stamp',
+      },
+       'includes': ['compile_js.gypi'],
+    },
+    {
+      'target_name': 'verify_feedback_consent.html',
+      'variables': {
+        'source_files': [
+          '<@(ar_feedback_consent_html_all_js_files)',
+          '<@(remoting_webapp_js_proto_files)',
+        ],
+        'out_file': '<(PRODUCT_DIR)/>(_target_name)_feedback_consent_jscompile.stamp',
+      },
+       'includes': ['compile_js.gypi'],
+    },
+  ],  # targets
+}