Refactor compile_js.gypi to support script_args and closure_args

remoting/webapp/build_template.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Keep in sync with 'remoting_webapp' target in remoting/remoting_client.gypi.
 
 import("//build/config/chrome_build.gni")
 import("//remoting/remoting_locales.gni")
 import("//remoting/remoting_options.gni")
 import("//remoting/remoting_version.gni")
 import("//remoting/webapp/files.gni")
+import("//third_party/closure_compiler/closure_args.gni")
 
 # The base remoting directory that is used as the root directory for file
 # references. Many of the scripts rely on the files being specified relative
 # to this directory.
 remoting_dir = "//remoting"
 
 buildtype = "Dev"
 if (!is_debug) {
   if (is_official_build) {
     buildtype = "Official"
@@ skipping 32 matching lines @@
     target_jscompile_stamp = "$target_gen_dir/${target_jscompile}.stamp"
     action(target_jscompile) {
       js_files = remoting_webapp_js_proto_files + invoker.js_files
 
       script = "../../third_party/closure_compiler/compile.py"
       inputs = js_files
       outputs = [
         target_jscompile_stamp,
       ]
 
-      args = [
-        "--strict",
-        "--no-single-file",
-        "--externs",
-        "../../third_party/closure_compiler/externs/chrome_extensions.js",
-        "--success-stamp",
-        rebase_path(target_jscompile_stamp, root_build_dir),
+      extra_closure_args = [
+        "jscomp_error=reportUnknownTypes",
+        "jscomp_error=duplicate",
+        "jscomp_error=misplacedTypeAnnotation",
       ]
-      args += rebase_path(js_files, root_build_dir)
+
+      args = rebase_path(js_files, root_build_dir)
+      args +=
+          [
+            "--no-single-file",
+            "--externs",
+            "../../third_party/closure_compiler/externs/chrome_extensions.js",
+            "--out-file",
+            rebase_path(target_jscompile_stamp, root_build_dir),
+            "--closure-args",
+          ] + closure_args + extra_closure_args
     }
   }
 
   action(target_name) {
     html_template_file = invoker.html_template_file
     html_template_include_files = invoker.html_template_include_files
     js_files = invoker.js_files
     html_output = invoker.html_output
 
     script = "build-html.py"
@@ skipping 325 matching lines @@
     args += [
       "--manifest_key",
       manifest_key,
     ]
     args += [
       "--app_client_id",
       app_client_id,
     ]
   }
 }