Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1152183002: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions… (Closed)

Created:
5 years, 7 months ago by vaibhav1.a
Modified:
5 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions/common/features/ BUG= Committed: https://crrev.com/3755726c1be7e5bb14d6f71e1018803e61d907a0 Cr-Commit-Position: refs/heads/master@{#331543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M extensions/common/features/base_feature_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/features/complex_feature_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/features/simple_feature.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
vaibhav1.a
Patch uploaded successfully, Kindly review
5 years, 7 months ago (2015-05-22 07:47:14 UTC) #2
dcheng
+kalman, who's actually an OWNER for this code.
5 years, 7 months ago (2015-05-22 13:40:22 UTC) #4
not at google - send to devlin
lgtm
5 years, 7 months ago (2015-05-22 16:56:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152183002/1
5 years, 7 months ago (2015-05-25 03:43:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/65718)
5 years, 7 months ago (2015-05-25 03:49:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152183002/1
5 years, 7 months ago (2015-05-27 06:28:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 07:09:07 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 07:10:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3755726c1be7e5bb14d6f71e1018803e61d907a0
Cr-Commit-Position: refs/heads/master@{#331543}

Powered by Google App Engine
This is Rietveld 408576698