Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: extensions/common/features/complex_feature_unittest.cc

Issue 1152183002: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/base_feature_provider.cc ('k') | extensions/common/features/simple_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/complex_feature_unittest.cc
diff --git a/extensions/common/features/complex_feature_unittest.cc b/extensions/common/features/complex_feature_unittest.cc
index 0f8a9ea4e53ee65c655f9e04340e3719beb56905..54355aa48ede7022727f27ef03aed4b5fe0d345c 100644
--- a/extensions/common/features/complex_feature_unittest.cc
+++ b/extensions/common/features/complex_feature_unittest.cc
@@ -27,7 +27,7 @@ TEST(ComplexFeatureTest, MultipleRulesWhitelist) {
.Set("extension_types", ListBuilder()
.Append("extension")).Build());
simple_feature->Parse(rule.get());
- features->push_back(simple_feature.release());
+ features->push_back(simple_feature.Pass());
// Rule: "legacy_packaged_app", whitelist "bar".
simple_feature.reset(new SimpleFeature);
@@ -36,7 +36,7 @@ TEST(ComplexFeatureTest, MultipleRulesWhitelist) {
.Set("extension_types", ListBuilder()
.Append("legacy_packaged_app")).Build();
simple_feature->Parse(rule.get());
- features->push_back(simple_feature.release());
+ features->push_back(simple_feature.Pass());
scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
@@ -88,7 +88,7 @@ TEST(ComplexFeatureTest, Dependencies) {
ListBuilder().Append("manifest:content_security_policy"))
.Build();
simple_feature->Parse(rule.get());
- features->push_back(simple_feature.release());
+ features->push_back(simple_feature.Pass());
// Rule which depends on an platform-app-only feature (serial).
simple_feature.reset(new SimpleFeature);
@@ -96,7 +96,7 @@ TEST(ComplexFeatureTest, Dependencies) {
.Set("dependencies", ListBuilder().Append("permission:serial"))
.Build();
simple_feature->Parse(rule.get());
- features->push_back(simple_feature.release());
+ features->push_back(simple_feature.Pass());
scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
« no previous file with comments | « extensions/common/features/base_feature_provider.cc ('k') | extensions/common/features/simple_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698