extensions/common/features/base_feature_provider.cc - Issue 1152183002: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/base_feature_provider.cc

Issue 1152183002: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/features/base_feature_provider.cc

diff --git a/extensions/common/features/base_feature_provider.cc b/extensions/common/features/base_feature_provider.cc

index 40807f41195a1d29dde9139e12e7fb9fa65b6fb9..9d24d84ad085bc7d7badd9f3a3b1ce920c69e16c 100644

--- a/extensions/common/features/base_feature_provider.cc

+++ b/extensions/common/features/base_feature_provider.cc

@@ -128,7 +128,7 @@ BaseFeatureProvider::BaseFeatureProvider(const base::DictionaryValue& root,

feature.get()))

continue;

- features->push_back(feature.release());

+ features->push_back(feature.Pass());

}

linked_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));

« no previous file with comments | « no previous file | extensions/common/features/complex_feature_unittest.cc » ('j') | no next file with comments »