Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1152103003: Returning scoped_ptr in SdchInfoToValue() instead of raw pointers in net/base (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning scoped_ptr in SdchInfoToValue() instead of raw pointers in net/base BUG=472381 Committed: https://crrev.com/a507cef665c52387379cfb0cc6c6cf64d171b9b8 Cr-Commit-Position: refs/heads/master@{#331750}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Incorporated review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M net/base/sdch_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/sdch_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/log/net_log_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-05-25 06:07:59 UTC) #2
eroman
https://codereview.chromium.org/1152103003/diff/1/net/base/sdch_manager.cc File net/base/sdch_manager.cc (right): https://codereview.chromium.org/1152103003/diff/1/net/base/sdch_manager.cc#newcode517 net/base/sdch_manager.cc:517: entry_list.reset(); Not correct. Also this was already done in ...
5 years, 7 months ago (2015-05-26 18:19:59 UTC) #3
payal.pandey
Please have a look again, Thanks.
5 years, 7 months ago (2015-05-27 06:30:58 UTC) #4
eroman
lgtm
5 years, 7 months ago (2015-05-27 18:33:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152103003/20001
5 years, 7 months ago (2015-05-28 04:47:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-28 07:15:44 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-28 07:16:36 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a507cef665c52387379cfb0cc6c6cf64d171b9b8
Cr-Commit-Position: refs/heads/master@{#331750}

Powered by Google App Engine
This is Rietveld 408576698