Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: net/base/sdch_manager.cc

Issue 1152103003: Returning scoped_ptr in SdchInfoToValue() instead of raw pointers in net/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/sdch_manager.h ('k') | net/log/net_log_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/sdch_manager.cc
diff --git a/net/base/sdch_manager.cc b/net/base/sdch_manager.cc
index b5d07ea08f4e5274d5c286f1e6a7b7ba12edb0a7..09b0aa42a40498339e67a169f906e32acfd3b469 100644
--- a/net/base/sdch_manager.cc
+++ b/net/base/sdch_manager.cc
@@ -489,7 +489,7 @@ void SdchManager::UrlSafeBase64Encode(const std::string& input,
std::replace(output->begin(), output->end(), '/', '_');
}
-base::Value* SdchManager::SdchInfoToValue() const {
+scoped_ptr<base::Value> SdchManager::SdchInfoToValue() const {
scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
value->SetBoolean("sdch_enabled", sdch_enabled());
@@ -528,7 +528,7 @@ base::Value* SdchManager::SdchInfoToValue() const {
}
value->Set("blacklisted", entry_list.Pass());
- return value.release();
+ return value.Pass();
}
} // namespace net
« no previous file with comments | « net/base/sdch_manager.h ('k') | net/log/net_log_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698