net/base/sdch_manager.h - Issue 1152103003: Returning scoped_ptr in SdchInfoToValue() instead of raw pointers in net/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/sdch_manager.h

Issue 1152103003: Returning scoped_ptr in SdchInfoToValue() instead of raw pointers in net/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/sdch_manager.h

diff --git a/net/base/sdch_manager.h b/net/base/sdch_manager.h

index 000d4989093025db82e42a21dd6f3a666ee79066..13ca3f8ba67f512359d24aa80a5e056a5133b668 100644

--- a/net/base/sdch_manager.h

+++ b/net/base/sdch_manager.h

@@ -184,7 +184,7 @@ class NET_EXPORT SdchManager {

void SetAllowLatencyExperiment(const GURL& url, bool enable);

- base::Value* SdchInfoToValue() const;

+ scoped_ptr<base::Value> SdchInfoToValue() const;

// Add an SDCH dictionary to our list of availible

// dictionaries. This addition will fail if addition is illegal

« no previous file with comments | « no previous file | net/base/sdch_manager.cc » ('j') | no next file with comments »