Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1151943003: Revert of Add PERSISTENT_MAP usage for GpuMemoryBuffers. (Closed)

Created:
5 years, 7 months ago by Chirantan Ekbote
Modified:
5 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, enne (OOO), jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, piman, sadrul, sievers+watch_chromium.org, sky, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add PERSISTENT_MAP usage for GpuMemoryBuffers. (patchset #11 id:330001 of https://codereview.chromium.org/1139903005/) Reason for revert: The is causing the freon chrome on chrome os build to fail. Looks like a case for PERSISTENT_MAP also needs to be added to ui::GbmSurfaceFactory::CanCreateNativePixmap() in ui/ozone/platform/drm/gbm_surface_factory.cc. Here is a link to a failing build: https://uberchromegw.corp.google.com/i/chromeos/builders/amd64-generic_freon%20chromium%20PFQ/builds/1151 Original issue's description: > Add PERSISTENT_MAP usage for GpuMemoryBuffers. > > A GpuMemoryBuffer with this usage flag will always point at the > same memory contents each time it is mapped. This will enable > partial tile updates by avoiding rastering content from the > previous frame again in the compositor. > > R=reveman,piman > BUG=489447 > > Committed: https://crrev.com/77180b4434d93f45022b8c65110344cdced4b19d > Cr-Commit-Position: refs/heads/master@{#330987} TBR=reveman@chromium.org,alexst@chromium.org,piman@chromium.org,sky@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489447 Committed: https://crrev.com/1b81bc40235207ece7fe8cae3e7c1d828f7aa68f Cr-Commit-Position: refs/heads/master@{#331140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -203 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +1 line, -13 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 3 chunks +28 lines, -46 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -13 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc View 2 chunks +1 line, -94 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 chunk +1 line, -4 lines 0 comments Download
M ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Chirantan Ekbote
Created Revert of Add PERSISTENT_MAP usage for GpuMemoryBuffers.
5 years, 7 months ago (2015-05-22 18:12:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151943003/1
5 years, 7 months ago (2015-05-22 18:13:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 18:15:27 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 18:16:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b81bc40235207ece7fe8cae3e7c1d828f7aa68f
Cr-Commit-Position: refs/heads/master@{#331140}

Powered by Google App Engine
This is Rietveld 408576698