Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1151943003: Revert of Add PERSISTENT_MAP usage for GpuMemoryBuffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/browser_gpu_memory_buffer_manager.cc ('k') | content/common/child_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 6bb177c39d9ba6386b1494252bddef5f0ce8ab11..66dfa9c9266c671eb288f7e72689772ed8297a5e 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -1133,22 +1133,10 @@
if (IsForceGpuRasterizationEnabled())
command_line->AppendSwitch(switches::kForceGpuRasterization);
- // TODO(reveman): We currently assume that the compositor will use BGRA_8888
- // if it's able to, and RGBA_8888 otherwise. Since we don't know what it will
- // use we hardcode BGRA_8888 here for now. We should instead
- // move decisions about GpuMemoryBuffer format to the browser embedder so we
- // know it here, and pass that decision to the compositor for each usage.
- // crbug.com/490362
- gfx::GpuMemoryBuffer::Format format = gfx::GpuMemoryBuffer::BGRA_8888;
-
- // TODO(danakj): When one-copy uploads support partial update, change this
- // usage to PERSISTENT_MAP for one-copy.
- gfx::GpuMemoryBuffer::Usage usage = gfx::GpuMemoryBuffer::MAP;
-
command_line->AppendSwitchASCII(
switches::kUseImageTextureTarget,
base::UintToString(
- BrowserGpuChannelHostFactory::GetImageTextureTarget(format, usage)));
+ BrowserGpuChannelHostFactory::GetImageTextureTarget()));
// Appending disable-gpu-feature switches due to software rendering list.
GpuDataManagerImpl* gpu_data_manager = GpuDataManagerImpl::GetInstance();
« no previous file with comments | « content/browser/gpu/browser_gpu_memory_buffer_manager.cc ('k') | content/common/child_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698