Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1151933005: Make sure that tracing is always cleaned up for v8_gc_times page_test (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan, prasadv, rmcilroy
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure that tracing is always cleaned up for v8_gc_times page_test BUG=491104 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/1d1d10c687de9424db5a66a89d179f11784d7ee8 Cr-Commit-Position: refs/heads/master@{#331590}

Patch Set 1 #

Patch Set 2 : Fix unittest #

Patch Set 3 : Rebase #

Patch Set 4 : Fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/perf/measurements/v8_gc_times.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/measurements/v8_gc_times_unittest.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_test_test_case.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 47 (22 generated)
nednguyen
5 years, 7 months ago (2015-05-22 20:56:31 UTC) #2
nednguyen
On 2015/05/22 20:56:31, nednguyen wrote: This is another reason of why writing a new page_test ...
5 years, 7 months ago (2015-05-22 20:57:09 UTC) #3
sullivan
lgtm
5 years, 7 months ago (2015-05-22 20:58:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/1
5 years, 7 months ago (2015-05-22 21:01:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL) mac_chromium_rel_ng on ...
5 years, 7 months ago (2015-05-22 21:13:14 UTC) #8
nednguyen
+prasadv: helppp on the bisect bots!!
5 years, 7 months ago (2015-05-22 21:20:36 UTC) #10
rmcilroy
Lgtm, thanks.
5 years, 7 months ago (2015-05-22 22:10:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/20001
5 years, 7 months ago (2015-05-22 22:19:21 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on ...
5 years, 7 months ago (2015-05-22 22:29:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/20001
5 years, 7 months ago (2015-05-23 12:02:02 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on ...
5 years, 7 months ago (2015-05-23 12:03:29 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/20001
5 years, 7 months ago (2015-05-25 03:35:05 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on ...
5 years, 7 months ago (2015-05-25 03:36:55 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/40001
5 years, 7 months ago (2015-05-25 17:11:54 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on ...
5 years, 7 months ago (2015-05-25 17:13:30 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/40001
5 years, 7 months ago (2015-05-26 14:45:35 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_compile_dbg_ng on ...
5 years, 7 months ago (2015-05-26 14:52:25 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/40001
5 years, 7 months ago (2015-05-26 15:22:58 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: mac_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_perf_bisect/builds/1533) win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, ...
5 years, 7 months ago (2015-05-26 15:29:40 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/40001
5 years, 7 months ago (2015-05-26 15:44:52 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/60820)
5 years, 7 months ago (2015-05-26 19:50:15 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/60001
5 years, 7 months ago (2015-05-27 15:38:19 UTC) #44
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-27 17:02:42 UTC) #45
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/1d1d10c687de9424db5a66a89d179f11784d7ee8 Cr-Commit-Position: refs/heads/master@{#331590}
5 years, 7 months ago (2015-05-27 17:03:53 UTC) #46
samuong
5 years, 7 months ago (2015-05-27 22:10:56 UTC) #47
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1147093008/ by samuong@chromium.org.

The reason for reverting is: I suspect this is causing failures on
telemetry_perf_unittests - see
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29 build
#37836 and later.

Powered by Google App Engine
This is Rietveld 408576698