|
|
DescriptionMake sure that tracing is always cleaned up for v8_gc_times page_test
BUG=491104
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Committed: https://crrev.com/1d1d10c687de9424db5a66a89d179f11784d7ee8
Cr-Commit-Position: refs/heads/master@{#331590}
Patch Set 1 #Patch Set 2 : Fix unittest #Patch Set 3 : Rebase #Patch Set 4 : Fix unittest #
Messages
Total messages: 47 (22 generated)
nednguyen@google.com changed reviewers: + rmcilroy@chromium.org, sullivan@chromium.org
On 2015/05/22 20:56:31, nednguyen wrote: This is another reason of why writing a new page_test is tricky and we should double down on using TBM.
lgtm
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, no build URL) android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) mac_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) win_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL)
nednguyen@google.com changed reviewers: + prasadv@chromium.org
+prasadv: helppp on the bisect bots!!
Lgtm, thanks.
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from sullivan@chromium.org, rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1151933005/#ps20001 (title: "Fix unittest")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, no build URL) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, no build URL) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, no build URL) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, no build URL) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, no build URL) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, no build URL) android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) mac_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) win_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, no build URL) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, no build URL) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, no build URL) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, no build URL) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, no build URL) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, no build URL) android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) mac_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) win_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, no build URL) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, no build URL) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, no build URL) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, no build URL) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, no build URL) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, no build URL) android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) mac_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) win_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL)
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from sullivan@chromium.org, rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1151933005/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, no build URL) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, no build URL) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, no build URL) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, no build URL) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, no build URL) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, no build URL) android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) mac_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) win_perf_bisect on tryserver.chromium.perf (JOB_FAILED, no build URL) win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_perf_bisect/...) win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, no build URL)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from sullivan@chromium.org, rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1151933005/#ps60001 (title: "Fix unittest")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933005/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/1d1d10c687de9424db5a66a89d179f11784d7ee8 Cr-Commit-Position: refs/heads/master@{#331590}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1147093008/ by samuong@chromium.org. The reason for reverting is: I suspect this is causing failures on telemetry_perf_unittests - see https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29 build #37836 and later. |