tools/perf/measurements/v8_gc_times.py - Issue 1151933005: Make sure that tracing is always cleaned up for v8_gc_times page_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/v8_gc_times.py

Issue 1151933005: Make sure that tracing is always cleaned up for v8_gc_times page_test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unittest Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/v8_gc_times.py

diff --git a/tools/perf/measurements/v8_gc_times.py b/tools/perf/measurements/v8_gc_times.py

index 01e2d0175848f9f9e3ff0cf3e0393d1b58c95562..c9649024f52c2babedb4d81baff5e386bf3d5df6 100644

--- a/tools/perf/measurements/v8_gc_times.py

+++ b/tools/perf/measurements/v8_gc_times.py

@@ -42,6 +42,10 @@ class V8GCTimes(page_test.PageTest):

renderer_process = timeline_model.GetRendererProcessFromTabId(tab.id)

self._AddV8MetricsToResults(renderer_process, results)

+ def CleanUpAfterPage(self, page, tab):

+ if tab.browser.platform.tracing_controller.is_tracing_running:

+ tab.browser.platform.tracing_controller.Stop()

def _AddV8MetricsToResults(self, process, results):

if process is None:

return

« no previous file with comments | « no previous file | tools/perf/measurements/v8_gc_times_unittest.py » ('j') | no next file with comments »