tools/perf/measurements/v8_gc_times_unittest.py - Issue 1151933005: Make sure that tracing is always cleaned up for v8_gc_times page_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/v8_gc_times_unittest.py

Issue 1151933005: Make sure that tracing is always cleaned up for v8_gc_times page_test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unittest Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/v8_gc_times_unittest.py

diff --git a/tools/perf/measurements/v8_gc_times_unittest.py b/tools/perf/measurements/v8_gc_times_unittest.py

index aaf816bd6bf5c0bd171f7e6098bec58fad9a482b..3ee121cfdffc4a3aaed72732823ce14a55f06685 100644

--- a/tools/perf/measurements/v8_gc_times_unittest.py

+++ b/tools/perf/measurements/v8_gc_times_unittest.py

@@ -238,6 +238,9 @@ class V8GCTimesTests(page_test_test_case.PageTestTestCase):

'Result for [' + key + '] - expected ' + str(expected[key]) +

' but got ' + str(actual[key]))

+ def testCleanUpTrace(self):

+ self.TestTracingCleanedUp(v8_gc_times.V8GCTimes, self._options)

def _ActualValues(results):

return dict(list(

« no previous file with comments | « tools/perf/measurements/v8_gc_times.py ('k') | tools/telemetry/telemetry/unittest_util/page_test_test_case.py » ('j') | no next file with comments »