Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1151793002: Make mixed samples contingent on auxiliary extensions (Closed)

Created:
5 years, 7 months ago by Chris Dalton
Modified:
5 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org, vbuzinov, Kimmo Kinnunen, Mark Kilgard
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make mixed samples contingent on auxiliary extensions Moves the cap for mixed samples into GrShaderCaps and does not enable it unless we have support for both dual source blending and multisample disable. Creates a dedicated cap for multisample disable. Reconfigures the mixed samples cap to indicate the collective capability of three different extensions: GL_NV_framebuffer_mixed_samples GL_NV_sample_mask_override_coverage GL_EXT_raster_multisample Imports tokens and procedures for GL_EXT_raster_multisample. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0edea2c8e76a9f5340a7a4960193757c4a5fb227

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 6 chunks +18 lines, -4 lines 1 comment Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Chris Dalton
https://codereview.chromium.org/1151793002/diff/1/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/1151793002/diff/1/src/gpu/gl/GrGLCaps.cpp#newcode258 src/gpu/gl/GrGLCaps.cpp:258: fMultisampleDisableSupport = false; This will eventually be replaced with ...
5 years, 7 months ago (2015-05-21 03:28:52 UTC) #2
bsalomon
lgtm BTW we are thinking seriously about never disabling multisampling and making the contract be ...
5 years, 7 months ago (2015-05-21 14:27:29 UTC) #3
Chris Dalton
On 2015/05/21 14:27:29, bsalomon wrote: > lgtm > > BTW we are thinking seriously about ...
5 years, 7 months ago (2015-05-21 14:45:48 UTC) #4
bsalomon
On 2015/05/21 14:45:48, Chris Dalton wrote: > On 2015/05/21 14:27:29, bsalomon wrote: > > lgtm ...
5 years, 7 months ago (2015-05-21 15:09:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151793002/1
5 years, 7 months ago (2015-05-21 15:16:20 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 15:27:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0edea2c8e76a9f5340a7a4960193757c4a5fb227

Powered by Google App Engine
This is Rietveld 408576698