Remove hexDigit check in CSSParserValueList

Remove hexDigit check in CSSParserValueList

There is no need to check the value in the HashToken if we use
Color::parseHexColor directly, so remove the check and make
sure we call Color::parseHexColor directly when dealing
with a CSSParserValue of type HexColor. This should
be more efficient too since we skip the check and
unneeded checks for different color values (rgb/rgba/named color).

Functionality covered by fast/css/invalid-predefined-color.html.

BUG=489144
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195840

[rwlbuis, 2015-05-21 19:56:31]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-05-21 19:56:31]

PTAL

[Timothy Loh, 2015-05-22 01:05:11]

https://codereview.chromium.org/1151593003/diff/1/Source/core/css/parser/CSSP...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1151593003/diff/1/Source/core/css/parser/CSSP...
Source/core/css/parser/CSSPropertyParser.cpp:5312: ASSERT(value->string[0] !=
'#');
I don't think this assertion is right (you can write things like #\#)

[Timothy Loh, 2015-05-24 23:38:09]

lgtm assuming you meant to send this out again after making changes :)

[rwlbuis, 2015-05-25 00:34:12]

On 2015/05/24 23:38:09, Timothy Loh wrote:
> lgtm assuming you meant to send this out again after making changes :)

Yes, I think I forgot the PRAL :) Thanks!

[rwlbuis, 2015-05-25 00:34:20]

On 2015/05/25 00:34:12, rwlbuis wrote:
> On 2015/05/24 23:38:09, Timothy Loh wrote:
> > lgtm assuming you meant to send this out again after making changes :)
> 
> Yes, I think I forgot the PRAL :) Thanks!

PTAL even

[rwlbuis, 2015-05-25 00:34:23]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-05-25 00:34:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151593003/20001

[commit-bot: I haz the power, 2015-05-25 02:13:38]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195840