Remove hexDigit check in CSSParserValueList

Source/core/css/parser/CSSPropertyParser.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 5064 matching lines @@
 {
     if (length < 4)
         return false;
     return characters[3] == '('
         && isASCIIAlphaCaselessEqual(characters[0], 'r')
         && isASCIIAlphaCaselessEqual(characters[1], 'g')
         && isASCIIAlphaCaselessEqual(characters[2], 'b');
 }
 
 template <typename CharacterType>
-static inline bool fastParseColorInternal(RGBA32& rgb, const CharacterType* characters, unsigned length , bool strict)
+static inline bool fastParseColorInternal(RGBA32& rgb, const CharacterType* characters, unsigned length, bool strict)
 {
     CSSPrimitiveValue::UnitType expect = CSSPrimitiveValue::CSS_UNKNOWN;
 
     if (length >= 4 && characters[0] == '#')
         return Color::parseHexColor(characters + 1, length - 1, rgb);
 
     if (!strict && length >= 3) {
         if (Color::parseHexColor(characters, length, rgb))
             return true;
     }
@@ skipping 202 matching lines @@
         ASSERT(numberToken->unit == CSSPrimitiveValue::CSS_NUMBER);
         ASSERT(unitToken->unit == CSSPrimitiveValue::CSS_IDENT);
         if (!numberToken->isInt || numberToken->fValue < 0)
             return false;
         String color = String::number(numberToken->fValue) + String(unitToken->string);
         if (color.length() > 6)
             return false;
         while (color.length() < 6)
             color = "0" + color;
         return fastParseColor(c, color, false);
-    } else if (value->unit == CSSParserValue::HexColor || value->unit == CSSPrimitiveValue::CSS_IDENT) {
-        if (!fastParseColor(c, value->string, !acceptQuirkyColors && value->unit == CSSPrimitiveValue::CSS_IDENT))
+    } else if (value->unit == CSSPrimitiveValue::CSS_IDENT) {
+        if (!fastParseColor(c, value->string, !acceptQuirkyColors))
             return false;
+    } else if (value->unit == CSSParserValue::HexColor) {
+        ASSERT(value->string[0] != '#');

[Timothy Loh, 2015/05/22 01:05:10]

I don't think this assertion is right (you can write things like #\#)

+        if (value->string.is8Bit())
+            return Color::parseHexColor(value->string.characters8(), value->string.length(), c);
+        return Color::parseHexColor(value->string.characters16(), value->string.length(), c);
     } else if (value->unit == CSSParserValue::Function &&
                 value->function->args != 0 &&
                 value->function->args->size() == 5 /* rgb + two commas */ &&
                 value->function->id == CSSValueRgb) {
         int colorValues[3];
         if (!parseColorParameters(value, colorValues, false))
             return false;
         c = makeRGB(colorValues[0], colorValues[1], colorValues[2]);
     } else {
         if (value->unit == CSSParserValue::Function &&
@@ skipping 3145 matching lines @@
         }
     }
 
     if (!list->length())
         return nullptr;
 
     return list.release();
 }
 
 } // namespace blink