Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: Source/core/css/parser/CSSParserValues.cpp

Issue 1151593003: Remove hexDigit check in CSSParserValueList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove ASSERT and add subtest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/CSSParserValues.cpp
diff --git a/Source/core/css/parser/CSSParserValues.cpp b/Source/core/css/parser/CSSParserValues.cpp
index eddad768cacdc3f3a8b0514c3c5636fb095d16e2..a9e236d42fe4d9510ee1563cf2edaba767a4238a 100644
--- a/Source/core/css/parser/CSSParserValues.cpp
+++ b/Source/core/css/parser/CSSParserValues.cpp
@@ -179,15 +179,6 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range, bool& usesRemU
break;
}
case HashToken:
- // FIXME: Move this logic to the property parser
- // This check prevents us from allowing #red and similar
- for (size_t i = 0; i < token.value().length(); ++i) {
- if (!isASCIIHexDigit(token.value()[i])) {
- destroyAndClear();
- return;
- }
- }
- // fallthrough
case StringToken:
case UrlToken: {
value.id = CSSValueInvalid;
« no previous file with comments | « LayoutTests/fast/css/script-tests/invalid-predefined-color.js ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698