Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1151543002: Revert of [Telemetry] Disable auto issuing record for thread_times (Closed)

Created:
5 years, 7 months ago by sullivan
Modified:
5 years, 7 months ago
Reviewers:
eakuefner, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Disable auto issuing record for thread_times (patchset #3 id:60001 of https://codereview.chromium.org/1140353003/) Reason for revert: Seems to have broken service_worker tests (http://crbug.com/490130) Original issue's description: > [Telemetry] Disable auto issuing record for thread_times > > BUG=444705 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/2905d303db21f120aab1914f98fe0e44284f82ed > Cr-Commit-Position: refs/heads/master@{#330613} TBR=eakuefner@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444705 Committed: https://crrev.com/d8cf830e1354f26030de86358128cdf7307330ff Cr-Commit-Position: refs/heads/master@{#330728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -29 lines) Patch
M tools/perf/measurements/blink_style.py View 2 chunks +9 lines, -11 lines 0 comments Download
M tools/perf/measurements/thread_times.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 4 chunks +5 lines, -12 lines 0 comments Download
M tools/perf/page_sets/key_idle_power_cases.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/tough_compositor_cases.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sullivan
Created Revert of [Telemetry] Disable auto issuing record for thread_times
5 years, 7 months ago (2015-05-20 13:41:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151543002/1
5 years, 7 months ago (2015-05-20 13:42:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 13:42:59 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 13:43:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8cf830e1354f26030de86358128cdf7307330ff
Cr-Commit-Position: refs/heads/master@{#330728}

Powered by Google App Engine
This is Rietveld 408576698