Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: tools/perf/measurements/thread_times.py

Issue 1151543002: Revert of [Telemetry] Disable auto issuing record for thread_times (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.core.platform import tracing_category_filter 5 from telemetry.core.platform import tracing_category_filter
6 from telemetry.page import page_test 6 from telemetry.page import page_test
7 from telemetry.web_perf.metrics import layout 7 from telemetry.web_perf.metrics import layout
8 8
9 from measurements import timeline_controller 9 from measurements import timeline_controller
10 from metrics import timeline 10 from metrics import timeline
11 11
12 12
13 class ThreadTimes(page_test.PageTest): 13 class ThreadTimes(page_test.PageTest):
14 def __init__(self, report_silk_details=False): 14 def __init__(self, report_silk_details=False):
15 super(ThreadTimes, self).__init__() 15 super(ThreadTimes, self).__init__()
16 self._timeline_controller = None 16 self._timeline_controller = None
17 self._report_silk_details = report_silk_details 17 self._report_silk_details = report_silk_details
18 18
19 def WillNavigateToPage(self, page, tab): 19 def WillNavigateToPage(self, page, tab):
20 self._timeline_controller = timeline_controller.TimelineController( 20 self._timeline_controller = timeline_controller.TimelineController()
21 enable_auto_issuing_record=False)
22 if self._report_silk_details: 21 if self._report_silk_details:
23 # We need the other traces in order to have any details to report. 22 # We need the other traces in order to have any details to report.
24 self._timeline_controller.trace_categories = None 23 self._timeline_controller.trace_categories = None
25 else: 24 else:
26 self._timeline_controller.trace_categories = \ 25 self._timeline_controller.trace_categories = \
27 tracing_category_filter.CreateNoOverheadFilter().filter_string 26 tracing_category_filter.CreateNoOverheadFilter().filter_string
28 self._timeline_controller.SetUp(page, tab) 27 self._timeline_controller.SetUp(page, tab)
29 28
30 def DidNavigateToPage(self, page, tab): 29 def DidNavigateToPage(self, page, tab):
31 self._timeline_controller.Start(tab) 30 self._timeline_controller.Start(tab)
32 31
33 def ValidateAndMeasurePage(self, page, tab, results): 32 def ValidateAndMeasurePage(self, page, tab, results):
34 self._timeline_controller.Stop(tab, results) 33 self._timeline_controller.Stop(tab, results)
35 metric = timeline.ThreadTimesTimelineMetric() 34 metric = timeline.ThreadTimesTimelineMetric()
36 renderer_thread = \ 35 renderer_thread = \
37 self._timeline_controller.model.GetRendererThreadFromTabId(tab.id) 36 self._timeline_controller.model.GetRendererThreadFromTabId(tab.id)
38 if self._report_silk_details: 37 if self._report_silk_details:
39 metric.details_to_report = timeline.ReportSilkDetails 38 metric.details_to_report = timeline.ReportSilkDetails
40 metric.AddResults(self._timeline_controller.model, renderer_thread, 39 metric.AddResults(self._timeline_controller.model, renderer_thread,
41 self._timeline_controller.smooth_records, results) 40 self._timeline_controller.smooth_records, results)
42 layout_metric = layout.LayoutMetric() 41 layout_metric = layout.LayoutMetric()
43 layout_metric.AddResults(self._timeline_controller.model, renderer_thread, 42 layout_metric.AddResults(self._timeline_controller.model, renderer_thread,
44 self._timeline_controller.smooth_records, results) 43 self._timeline_controller.smooth_records, results)
45 44
46 def CleanUpAfterPage(self, _, tab): 45 def CleanUpAfterPage(self, _, tab):
47 if self._timeline_controller: 46 if self._timeline_controller:
48 self._timeline_controller.CleanUp(tab) 47 self._timeline_controller.CleanUp(tab)
OLDNEW
« no previous file with comments | « tools/perf/measurements/blink_style.py ('k') | tools/perf/measurements/thread_times_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698