Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/perf/measurements/blink_style.py

Issue 1151543002: Revert of [Telemetry] Disable auto issuing record for thread_times (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/blink_style.py
diff --git a/tools/perf/measurements/blink_style.py b/tools/perf/measurements/blink_style.py
index b46eab153b22eefb22cca4767c92ec8a170d936f..f9ef8759dc1c75127d87fae3075c2e3c7877cf86 100644
--- a/tools/perf/measurements/blink_style.py
+++ b/tools/perf/measurements/blink_style.py
@@ -6,7 +6,6 @@
from collections import defaultdict
from telemetry.core import util
from telemetry.core import exceptions
-from telemetry.page import action_runner
from telemetry.page import page_test
from telemetry.value import scalar
@@ -29,16 +28,15 @@
self._controller.CleanUp(tab)
def ValidateAndMeasurePage(self, page, tab, results):
- runner = action_runner.ActionRunner(tab)
- with runner.CreateInteraction('wait-for-quiescence'):
- tab.ExecuteJavaScript('console.time("");')
- try:
- util.WaitFor(tab.HasReachedQuiescence, 15)
- except exceptions.TimeoutException:
- # Some sites never reach quiesence. As this benchmark normalizes/
- # categories results, it shouldn't be necessary to reach the same
- # state on every run.
- pass
+ tab.ExecuteJavaScript('console.time("wait-for-quiescence");')
+ try:
+ util.WaitFor(tab.HasReachedQuiescence, 15)
+ except exceptions.TimeoutException:
+ # Some sites never reach quiesence. As this benchmark normalizes/
+ # categories results, it shouldn't be necessary to reach the same
+ # state on every run.
+ pass
+ tab.ExecuteJavaScript('console.timeEnd("wait-for-quiescence");')
tab.ExecuteJavaScript(
'console.time("style-update");'
« no previous file with comments | « no previous file | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698