wm: public window_types.

wm: public window_types.

Patch manually generated by:

$ git grep -l aura::client::WINDOW_TYPE | xargs sed -i -e 's/aura::client::WINDOW_TYPE/ui::wm::WINDOW_TYPE/g'
$ git commit -a -m.
$ git clang-format HEAD^ --style=Chromium
$ git commit -a -m.

* Move window_types.h header from ui/aura/client/ to ui/wm/public/

BUG=319638
TEST=ash_unittests, aura_unittests, views_unittests, unit_tests
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241752

[Ben Goodger (Google), 2013-12-18 06:08:11]

lgtm, but see note below:

https://codereview.chromium.org/115153002/diff/120001/ash/shell/window_watche...
File ash/shell/window_watcher_shelf_item_delegate.cc (right):

https://codereview.chromium.org/115153002/diff/120001/ash/shell/window_watche...
ash/shell/window_watcher_shelf_item_delegate.cc:27: if (window->type() ==
ui::wm::WINDOW_TYPE_PANEL)
how about just "wm::"

?

[tfarina, 2013-12-18 12:45:48]

https://codereview.chromium.org/115153002/diff/120001/ash/shell/window_watche...
File ash/shell/window_watcher_shelf_item_delegate.cc (right):

https://codereview.chromium.org/115153002/diff/120001/ash/shell/window_watche...
ash/shell/window_watcher_shelf_item_delegate.cc:27: if (window->type() ==
ui::wm::WINDOW_TYPE_PANEL)
On 2013/12/18 06:08:12, Ben Goodger (Google) wrote:
> how about just "wm::"
> 
> ?
Initially I went with just "wm::", but it caused conflicts in ash, because in
ash there is already a "namespace wm", so I had to use ::wm, but then that was
an error in a template class.

[commit-bot: I haz the power, 2013-12-18 12:46:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/115153002/120001

[commit-bot: I haz the power, 2013-12-18 13:51:10]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-12-18 22:33:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/115153002/140001

[commit-bot: I haz the power, 2013-12-18 23:16:18]

Retried try job too often on linux_rel for step(s) check_deps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-18 23:22:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/115153002/160001

[commit-bot: I haz the power, 2013-12-19 00:01:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/115153002/160001

[commit-bot: I haz the power, 2013-12-19 01:50:10]

Change committed as 241752

[Ben Goodger (Google), 2014-02-27 07:38:54]

OK so I just realized this creates a circular dep/layering violation.

You use ui/wm/public from ui/aura. ui/aura isn't allowed to depend on
ui/wm/anything. So that needs to change. My preference is that the type gets
stored on the window in a property.

Second, I'd really like this namespace to be wm:: not ui::wm::, as I requested
in my earlier comment. I'd rather we come up with some other solution to deal
with ash. Perhaps ash shouldn't have a wm:: namespace at all. I think it's
rather pointless over there. I'd like to eventually kill the ui:: namespace, not
add more to it.

[tfarina, 2014-02-27 16:50:16]

On 2014/02/27 07:38:54, Ben Goodger (Google) wrote:
> OK so I just realized this creates a circular dep/layering violation.
> 
> You use ui/wm/public from ui/aura. ui/aura isn't allowed to depend on
> ui/wm/anything. So that needs to change. My preference is that the type gets
> stored on the window in a property.
> 
Filed crbug.com/347580 to address this.

> Second, I'd really like this namespace to be wm:: not ui::wm::, as I requested
> in my earlier comment. I'd rather we come up with some other solution to deal
> with ash. Perhaps ash shouldn't have a wm:: namespace at all. I think it's
> rather pointless over there. I'd like to eventually kill the ui:: namespace,
not
> add more to it.
And crbug.com/347582 to address this.