Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 1151263002: Fix positioning of autofill popup on rtl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
index e7ebd3b80e00eca4c483df98a513a9f387b63357..2ad6cbeaba55848313290ccf03ea7e5e8a41afc5 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
@@ -101,11 +101,11 @@ AutofillPopupControllerImpl::AutofillPopupControllerImpl(
const gfx::RectF& element_bounds,
base::i18n::TextDirection text_direction)
: controller_common_(new PopupControllerCommon(element_bounds,
+ text_direction,
container_view,
web_contents)),
view_(NULL),
delegate_(delegate),
- text_direction_(text_direction),
weak_ptr_factory_(this) {
ClearState();
controller_common_->SetKeyPressCallback(
@@ -395,7 +395,7 @@ const gfx::RectF& AutofillPopupControllerImpl::element_bounds() const {
}
bool AutofillPopupControllerImpl::IsRTL() const {
- return text_direction_ == base::i18n::RIGHT_TO_LEFT;
+ return controller_common_->is_rtl();
}
size_t AutofillPopupControllerImpl::GetLineCount() const {

Powered by Google App Engine
This is Rietveld 408576698