Fix positioning of autofill popup on rtl

chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/logging.h"
@@ skipping 83 matching lines @@
   return controller->GetWeakPtr();
 }
 
 AutofillPopupControllerImpl::AutofillPopupControllerImpl(
     base::WeakPtr<AutofillPopupDelegate> delegate,
     content::WebContents* web_contents,
     gfx::NativeView container_view,
     const gfx::RectF& element_bounds,
     base::i18n::TextDirection text_direction)
     : controller_common_(new PopupControllerCommon(element_bounds,
+                                                   text_direction,
                                                    container_view,
                                                    web_contents)),
       view_(NULL),
       delegate_(delegate),
-      text_direction_(text_direction),
       weak_ptr_factory_(this) {
   ClearState();
   controller_common_->SetKeyPressCallback(
       base::Bind(&AutofillPopupControllerImpl::HandleKeyPressEvent,
                  base::Unretained(this)));
 #if !defined(OS_ANDROID)
   label_font_list_ = value_font_list_.DeriveWithSizeDelta(kLabelFontSizeDelta);
   title_font_list_ = value_font_list_.DeriveWithStyle(gfx::Font::BOLD);
 #if defined(OS_MACOSX)
   // There is no italic version of the system font.
@@ skipping 269 matching lines @@
 
 gfx::NativeView AutofillPopupControllerImpl::container_view() {
   return controller_common_->container_view();
 }
 
 const gfx::RectF& AutofillPopupControllerImpl::element_bounds() const {
   return controller_common_->element_bounds();
 }
 
 bool AutofillPopupControllerImpl::IsRTL() const {
-  return text_direction_ == base::i18n::RIGHT_TO_LEFT;
+  return controller_common_->is_rtl();
 }
 
 size_t AutofillPopupControllerImpl::GetLineCount() const {
   return suggestions_.size();
 }
 
 const autofill::Suggestion& AutofillPopupControllerImpl::GetSuggestionAt(
     size_t row) const {
   return suggestions_[row];
 }
@@ skipping 251 matching lines @@
   popup_bounds_ = gfx::Rect();
 
   suggestions_.clear();
   elided_values_.clear();
   elided_labels_.clear();
 
   selected_line_ = kNoSelection;
 }
 
 }  // namespace autofill