chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc - Issue 1151263002: Fix positioning of autofill popup on rtl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 1151263002: Fix positioning of autofill popup on rtl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc ('k') | chrome/browser/ui/autofill/popup_controller_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

index e3dabb19932dce24ca4c66de36bd238df7dda707..fb31720cef42f2f0b5e9b5c73f3285422151e48d 100644

--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

@@ -83,7 +83,11 @@ PasswordGenerationPopupControllerImpl::PasswordGenerationPopupControllerImpl(

driver_(driver),

observer_(observer),

generator_(new PasswordGenerator(max_length)),

- controller_common_(bounds, container_view, web_contents),

+ // TODO(estade): use correct text direction.

Garrett Casto 2015/05/26 04:30:14 Shouldn't this just be base::i18n::GetTextDirecti

Evan Stade 2015/05/26 18:30:47 I suspect (but am not certain) you want to do the

+ controller_common_(bounds,

+ base::i18n::LEFT_TO_RIGHT,

+ container_view,

+ web_contents),

password_selected_(false),

display_password_(false),

weak_ptr_factory_(this) {