[turbofan] Rework Node guts to save space.

[turbofan] Rework Node guts to save space.

This reduces the storage per-Node storage from 7 words to 6 and per-edge
storage from 6 words to 4.
On average this is about 10%-15% space savings over the whole graph.

Remove the use of std::deque as the out-of-line storage for inputs.
Reduce size of Use links and use pointer arithmetic to find Node
from Use.

R=mstarzinger@chromium.org,jarin@chromium.org
BUG=

Committed: https://crrev.com/65b66634de40355498b37dfbdcefd55773ac48a1
Cr-Commit-Position: refs/heads/master@{#28583}

[Michael Starzinger, 2015-05-21 14:14:02]

LGTM. I like it. Just a couple of comments.

https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h
File src/compiler/node.h (right):

https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h#new...
src/compiler/node.h:95: 
nit: Maybe #undef BOUNDS_CHECK here again.

https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h#new...
src/compiler/node.h:297: typedef BitField<unsigned, 29, 4> InlineCapacityField;
Looks like this is exceeding 32-bit here?

https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h#new...
src/compiler/node.h:319: #define VERIFY(node) Verify(node)
This macro probably cannot be undef'ed, because it's used in the .cc-file. So
can we move it into the .cc-file (or at least choose a slightly less ambiguous
name like VERIFY_NODE for it), because it would "leak" into many compilation
units.

[titzer, 2015-05-21 15:11:20]

https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h
File src/compiler/node.h (right):

https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h#new...
src/compiler/node.h:95: 
On 2015/05/21 14:14:02, Michael Starzinger wrote:
> nit: Maybe #undef BOUNDS_CHECK here again.

Done.

https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h#new...
src/compiler/node.h:297: typedef BitField<unsigned, 29, 4> InlineCapacityField;
On 2015/05/21 14:14:02, Michael Starzinger wrote:
> Looks like this is exceeding 32-bit here?

Finger math is best math!

https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h#new...
src/compiler/node.h:319: #define VERIFY(node) Verify(node)
On 2015/05/21 14:14:02, Michael Starzinger wrote:
> This macro probably cannot be undef'ed, because it's used in the .cc-file. So
> can we move it into the .cc-file (or at least choose a slightly less ambiguous
> name like VERIFY_NODE for it), because it would "leak" into many compilation
> units.

Fixed this to be a regular function in debug mode, inline empty function in
release mode.

[titzer, 2015-05-22 11:07:49]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-05-22 11:07:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1150923003/#ps140001
(title: "Avoid quadratic verification explosion.")

[commit-bot: I haz the power, 2015-05-22 11:08:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150923003/140001

[commit-bot: I haz the power, 2015-05-22 11:13:12]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-05-22 11:13:25]

Patchset 8 (id:??) landed as
https://crrev.com/65b66634de40355498b37dfbdcefd55773ac48a1
Cr-Commit-Position: refs/heads/master@{#28583}