Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1150863002: Make DictionaryValue::DeepCopyWithoutEmptyChildren return a scoped_ptr (Closed)

Created:
5 years, 7 months ago by Evan Stade
Modified:
5 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, wjmaclean, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DictionaryValue::DeepCopyWithoutEmptyChildren return a scoped_ptr BUG=none Committed: https://crrev.com/6e04d5002ba4cff956df7f246c8bf3bfe0c8a6f2 Cr-Commit-Position: refs/heads/master@{#331223}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove semicolons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -52 lines) Patch
M base/values.h View 1 chunk +1 line, -1 line 0 comments Download
M base/values.cc View 2 chunks +41 lines, -35 lines 0 comments Download
M base/values_unittest.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_calculator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/chromeos/lib/rlz_value_store_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Evan Stade
5 years, 7 months ago (2015-05-21 22:40:51 UTC) #2
brettw
LGTM with semicolons fixed. https://codereview.chromium.org/1150863002/diff/1/base/values_unittest.cc File base/values_unittest.cc (right): https://codereview.chromium.org/1150863002/diff/1/base/values_unittest.cc#newcode683 base/values_unittest.cc:683: ; Did you screw up ...
5 years, 7 months ago (2015-05-22 20:59:33 UTC) #3
Evan Stade
https://codereview.chromium.org/1150863002/diff/1/base/values_unittest.cc File base/values_unittest.cc (right): https://codereview.chromium.org/1150863002/diff/1/base/values_unittest.cc#newcode683 base/values_unittest.cc:683: ; On 2015/05/22 20:59:32, brettw wrote: > Did you ...
5 years, 7 months ago (2015-05-22 21:28:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150863002/20001
5 years, 7 months ago (2015-05-22 21:49:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-23 02:42:19 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-23 02:43:09 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e04d5002ba4cff956df7f246c8bf3bfe0c8a6f2
Cr-Commit-Position: refs/heads/master@{#331223}

Powered by Google App Engine
This is Rietveld 408576698