chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc - Issue 1150863002: Make DictionaryValue::DeepCopyWithoutEmptyChildren return a scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc

Issue 1150863002: Make DictionaryValue::DeepCopyWithoutEmptyChildren return a scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove semicolons Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc

diff --git a/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc b/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc

index c389169a8c5518794e57359d3536981ecb82bc05..93b64405187f63104ad52fb6aa6aa44f4358af38 100644

--- a/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc

+++ b/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc

@@ -130,8 +130,8 @@ void ChromeZoomLevelPrefs::ExtractPerHostZoomLevels(

const base::DictionaryValue* host_zoom_dictionary,

bool sanitize_partition_host_zoom_levels) {

std::vector<std::string> keys_to_remove;

- scoped_ptr<base::DictionaryValue> host_zoom_dictionary_copy(

- host_zoom_dictionary->DeepCopyWithoutEmptyChildren());

+ scoped_ptr<base::DictionaryValue> host_zoom_dictionary_copy =

+ host_zoom_dictionary->DeepCopyWithoutEmptyChildren();

for (base::DictionaryValue::Iterator i(*host_zoom_dictionary_copy);

!i.IsAtEnd();

i.Advance()) {

« no previous file with comments | « chrome/browser/prefs/tracked/pref_hash_calculator.cc ('k') | rlz/chromeos/lib/rlz_value_store_chromeos.cc » ('j') | no next file with comments »