base/values.h - Issue 1150863002: Make DictionaryValue::DeepCopyWithoutEmptyChildren return a scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.h

Issue 1150863002: Make DictionaryValue::DeepCopyWithoutEmptyChildren return a scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove semicolons Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/values.h

diff --git a/base/values.h b/base/values.h

index e32edecf2ec347d3c146a86920cbec389f584147..7feef9da541b0d00990510047ce7a7717cab0a9f 100644

--- a/base/values.h

+++ b/base/values.h

@@ -338,7 +338,7 @@ class BASE_EXPORT DictionaryValue : public Value {

// Makes a copy of |this| but doesn't include empty dictionaries and lists in

// the copy. This never returns NULL, even if |this| itself is empty.

- DictionaryValue* DeepCopyWithoutEmptyChildren() const;

+ scoped_ptr<DictionaryValue> DeepCopyWithoutEmptyChildren() const;

// Merge |dictionary| into this dictionary. This is done recursively, i.e. any

// sub-dictionaries will be merged as well. In case of key collisions, the

« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »