Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1150563003: Rename InterfacePtr's WaitForIncomingMethodCall() -> WaitForIncomingResponse(). (Closed)

Created:
5 years, 7 months ago by viettrungluu
Modified:
5 years, 7 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename InterfacePtr's WaitForIncomingMethodCall() -> WaitForIncomingResponse(). R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c23bde8b044733245d7f2ccd94f1ad6a8173e820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -144 lines) Patch
M examples/apptest/example_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/child_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/icu/icu.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_apptest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/files/public/c/lib/directory_wrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/files/public/c/lib/file_fd_impl.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M mojo/services/files/public/c/tests/mojio_impl_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/files/public/c/tests/test_utils.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M services/files/directory_impl_unittest.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M services/files/file_impl_unittest.cc View 41 chunks +61 lines, -61 lines 0 comments Download
M services/files/files_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/http_server_apptest.cc View 6 chunks +4 lines, -12 lines 0 comments Download
M services/js/echo_apptest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M services/js/network_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/js/pingpong_apptest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/nacl/content_handler_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/python/mojo_url_redirector/mojo_url_redirector_apptest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_apptest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M shell/shell_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 7 months ago (2015-05-20 23:33:02 UTC) #1
jamesr
lgtm
5 years, 7 months ago (2015-05-21 16:53:27 UTC) #2
viettrungluu
5 years, 7 months ago (2015-05-21 16:53:57 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c23bde8b044733245d7f2ccd94f1ad6a8173e820 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698