Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: services/js/echo_apptest.cc

Issue 1150563003: Rename InterfacePtr's WaitForIncomingMethodCall() -> WaitForIncomingResponse(). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/http_server/http_server_apptest.cc ('k') | services/js/network_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/js/echo_apptest.cc
diff --git a/services/js/echo_apptest.cc b/services/js/echo_apptest.cc
index 220aaa399ddb67d688c65d4e6e1bf003a44e5c97..daf59d3ed2983d2154422d06b0a45c2a5ca305b9 100644
--- a/services/js/echo_apptest.cc
+++ b/services/js/echo_apptest.cc
@@ -69,7 +69,7 @@ TEST_F(JSEchoTest, EchoString) {
String foo;
EchoStringCallback callback(&foo);
echo_service_->EchoString("foo", callback);
- EXPECT_TRUE(echo_service_.WaitForIncomingMethodCall());
+ EXPECT_TRUE(echo_service_.WaitForIncomingResponse());
EXPECT_EQ("foo", foo);
echo_service_->Quit();
}
@@ -78,7 +78,7 @@ TEST_F(JSEchoTest, EchoEmptyString) {
String empty;
EchoStringCallback callback(&empty);
echo_service_->EchoString("", callback);
- EXPECT_TRUE(echo_service_.WaitForIncomingMethodCall());
+ EXPECT_TRUE(echo_service_.WaitForIncomingResponse());
EXPECT_EQ("", empty);
echo_service_->Quit();
}
@@ -87,7 +87,7 @@ TEST_F(JSEchoTest, EchoNullString) {
String null;
EchoStringCallback callback(&null);
echo_service_->EchoString(nullptr, callback);
- EXPECT_TRUE(echo_service_.WaitForIncomingMethodCall());
+ EXPECT_TRUE(echo_service_.WaitForIncomingResponse());
EXPECT_TRUE(null.is_null());
echo_service_->Quit();
}
@@ -98,7 +98,7 @@ TEST_F(JSEchoTest, ShareEchoService) {
bool returned_value;
ShareEchoServiceCallback callback(&returned_value);
echo_service_->ShareEchoService(callback);
- EXPECT_TRUE(echo_service_.WaitForIncomingMethodCall());
+ EXPECT_TRUE(echo_service_.WaitForIncomingResponse());
EXPECT_TRUE(returned_value);
echo_service_->Quit();
}
@@ -115,7 +115,7 @@ TEST_F(JSServiceProviderEchoTest, UseApplicationServiceProvider) {
String foo;
EchoStringCallback callback(&foo);
echo_service->EchoString("foo", callback);
- EXPECT_TRUE(echo_service.WaitForIncomingMethodCall());
+ EXPECT_TRUE(echo_service.WaitForIncomingResponse());
EXPECT_EQ("foo", foo);
echo_service->Quit();
}
« no previous file with comments | « services/http_server/http_server_apptest.cc ('k') | services/js/network_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698