services/js/pingpong_apptest.cc - Issue 1150563003: Rename InterfacePtr's WaitForIncomingMethodCall() -> WaitForIncomingResponse().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/js/pingpong_apptest.cc

Issue 1150563003: Rename InterfacePtr's WaitForIncomingMethodCall() -> WaitForIncomingResponse(). (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/js/pingpong_apptest.cc

diff --git a/services/js/pingpong_apptest.cc b/services/js/pingpong_apptest.cc

index e78415a4940014a31d8cd1e3daa27892f1d43900..e5e4ad3a43f37ad9d2122159a14607a26adb1a03 100644

--- a/services/js/pingpong_apptest.cc

+++ b/services/js/pingpong_apptest.cc

@@ -83,7 +83,7 @@ TEST_F(JSPingPongTest, PingTargetURL) {

bool returned_value = false;

PingTargetCallback callback(&returned_value);

pingpong_service_->PingTargetURL(JSAppURL("pingpong_target.js"), 9, callback);

- EXPECT_TRUE(pingpong_service_.WaitForIncomingMethodCall());

+ EXPECT_TRUE(pingpong_service_.WaitForIncomingResponse());

EXPECT_TRUE(returned_value);

pingpong_service_->Quit();

}

@@ -96,7 +96,7 @@ TEST_F(JSPingPongTest, PingTargetService) {