Remove the SCT viewer UI

Remove the SCT viewer UI

It is not implemented across all platforms and has a few rough polish
edges that are unlikely to get fixed. As part of the general work
towards simplifying the website settings UI, remove the SCT viewer.

Details about the SCTs are available via chrome://net-internals,
and will remain there until a more holistic view is provided by the
ongoing DevTools work

BUG=477552
Committed: https://crrev.com/b5e652718d5a1cf425e3517347d788c8da00420e
Cr-Commit-Position: refs/heads/master@{#331710}

[Ryan Sleevi, 2015-05-26 20:07:09]

rsleevi@chromium.org changed reviewers:
+ felt@chromium.org, pkasting@chromium.org

[Ryan Sleevi, 2015-05-26 20:07:10]

felt@chromium.org: Please review changes in chrome/browser/ui/website_settings

pkasting@chromium.org: Please review changes in chrome/browser/ui

Context for Peter: This is Chrome UI that wasn't implemented across all
platforms before launching. In 28 days across all platforms, it shows fewer than
5000 accesses. felt@ et-al on the -enamel@ side are doing a retrofit for this,
moving it to a different place, but inconsistent platforms bother me enough to
rip this code out.

chrome://net-internals can be used for the 5000-or-so doing this (which is
likely a mix between Googlers and CAs more than actual users)

[Peter Kasting, 2015-05-26 20:16:55]

Hmm, fixing that linebreaking wouldn't have been hard... just need to properly
set the multiline status and layout manager.

Whatever, though.  LGTM

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
(right):

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:738:
views::Link* secondary_link,
This argument always seems to be null now, so I think it should be removed.

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings.h (right):

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings.h:87: // No longer used;
indicated a UI viewer for SCTs
Nit: trailing period

[felt, 2015-05-26 20:21:32]

Eran, I'd like to hear your thoughts on this. Should this be deleted, or moved
behind a flag until you are able to fix/finish it? Of course, it only makes
sense to keep it behind a flag if we think you're going to actually fix/finish
it within a reasonable period of time.

[Ryan Sleevi, 2015-05-26 20:22:59]

On 2015/05/26 20:21:32, felt wrote:
> Eran, I'd like to hear your thoughts on this. Should this be deleted, or moved
> behind a flag until you are able to fix/finish it? Of course, it only makes
> sense to keep it behind a flag if we think you're going to actually fix/finish
> it within a reasonable period of time.

From our F2F in April, there was consensus to remove this code.

[felt, 2015-05-26 20:38:12]

lgtm

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings.h (right):

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings.h:91: WEBSITE_SETTINGS_COUNT
Should the value of WEBSITE_SETTINGS_COUNT also be specified?

[Ryan Sleevi, 2015-05-26 20:47:50]

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings.h (right):

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings.h:91: WEBSITE_SETTINGS_COUNT
On 2015/05/26 20:38:12, felt wrote:
> Should the value of WEBSITE_SETTINGS_COUNT also be specified?

A quick scan of histogram enums with explicit values suggests no (

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/bac...

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...
)

[felt, 2015-05-26 20:50:50]

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings.h (right):

https://codereview.chromium.org/1150173002/diff/20001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings.h:91: WEBSITE_SETTINGS_COUNT
On 2015/05/26 20:47:50, Ryan Sleevi wrote:
> On 2015/05/26 20:38:12, felt wrote:
> > Should the value of WEBSITE_SETTINGS_COUNT also be specified?
> 
> A quick scan of histogram enums with explicit values suggests no (
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/bac...
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...
> )

sg

[Ryan Sleevi, 2015-05-27 23:03:47]

The CQ bit was checked by rsleevi@chromium.org

[Ryan Sleevi, 2015-05-27 23:03:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1150173002/#ps40001
(title: "Review feedback")

[commit-bot: I haz the power, 2015-05-27 23:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150173002/40001

[commit-bot: I haz the power, 2015-05-28 01:13:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-28 01:14:31]

Patchset 3 (id:??) landed as
https://crrev.com/b5e652718d5a1cf425e3517347d788c8da00420e
Cr-Commit-Position: refs/heads/master@{#331710}

[Eran Messeri, 2015-05-28 08:55:29]

eranm@chromium.org changed reviewers:
+ eranm@chromium.org

[Eran Messeri, 2015-05-28 08:55:29]

LGTM - I agree with the reasons behind removing this code and that a better
place would be with the rest of the security details in DevTools.