Remove the SCT viewer UI

chrome/browser/ui/website_settings/website_settings.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/task/cancelable_task_tracker.h"
@@ skipping 60 matching lines @@
     SITE_IDENTITY_STATUS_ADMIN_PROVIDED_CERT,
     // The website provided a valid certificate, but the certificate or chain
     // is using a deprecated signature algorithm.
     SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
   };
 
   // UMA statistics for WebsiteSettings. Do not reorder or remove existing
   // fields.
   enum WebsiteSettingsAction {
     WEBSITE_SETTINGS_OPENED = 0,
-    WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED,
-    WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED,
-    WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY,
-    WEBSITE_SETTINGS_COOKIES_DIALOG_OPENED,
-    WEBSITE_SETTINGS_CHANGED_PERMISSION,
-    WEBSITE_SETTINGS_CERTIFICATE_DIALOG_OPENED,
-    WEBSITE_SETTINGS_TRANSPARENCY_VIEWER_OPENED,
-    WEBSITE_SETTINGS_CONNECTION_HELP_OPENED,
-    WEBSITE_SETTINGS_SITE_SETTINGS_OPENED,
+    WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED = 1,
+    WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED = 2,
+    WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY = 3,
+    WEBSITE_SETTINGS_COOKIES_DIALOG_OPENED = 4,
+    WEBSITE_SETTINGS_CHANGED_PERMISSION = 5,
+    WEBSITE_SETTINGS_CERTIFICATE_DIALOG_OPENED = 6,
+    // No longer used; indicated a UI viewer for SCTs

[Peter Kasting, 2015/05/26 20:16:55]

Nit: trailing period

+    // WEBSITE_SETTINGS_TRANSPARENCY_VIEWER_OPENED = 7,
+    WEBSITE_SETTINGS_CONNECTION_HELP_OPENED = 8,
+    WEBSITE_SETTINGS_SITE_SETTINGS_OPENED = 9,
     WEBSITE_SETTINGS_COUNT

[felt, 2015/05/26 20:38:12]

Should the value of WEBSITE_SETTINGS_COUNT also be specified?

[Ryan Sleevi, 2015/05/26 20:47:50]

A quick scan of histogram enums with explicit values suggests no (

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/bac...

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...
)

[felt, 2015/05/26 20:50:50]

sg

   };
 
   // Creates a WebsiteSettings for the passed |url| using the given |ssl| status
   // object to determine the status of the site's connection. The
   // |WebsiteSettings| takes ownership of the |ui|.
   WebsiteSettings(WebsiteSettingsUI* ui,
                   Profile* profile,
                   TabSpecificContentSettings* tab_specific_content_settings,
                   InfoBarService* infobar_service,
                   const GURL& url,
@@ skipping 140 matching lines @@
   // Service for managing SSL error page bypasses. Used to revoke bypass
   // decisions by users.
   ChromeSSLHostStateDelegate* chrome_ssl_host_state_delegate_;
 
   bool did_revoke_user_ssl_decisions_;
 
   DISALLOW_COPY_AND_ASSIGN(WebsiteSettings);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_