net/cert/ct_signed_certificate_timestamp_log_param.h - Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/ct_signed_certificate_timestamp_log_param.h

Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/web_request/web_request_api_helpers.cc ('K') | « net/cert/cert_policy_enforcer.cc ('k') | net/cert/ct_signed_certificate_timestamp_log_param.cc » ('j') | net/cert/multi_threaded_cert_verifier.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/ct_signed_certificate_timestamp_log_param.h

diff --git a/net/cert/ct_signed_certificate_timestamp_log_param.h b/net/cert/ct_signed_certificate_timestamp_log_param.h

index 25e1fb58954a86210438e2e45a1a24df7fd9d830..4b1ccb3164e399741b78fbaa14f35e31e939860b 100644

--- a/net/cert/ct_signed_certificate_timestamp_log_param.h

+++ b/net/cert/ct_signed_certificate_timestamp_log_param.h

@@ -17,7 +17,7 @@ struct CTVerifyResult;

// logged in the NetLog.

// See the documentation for SIGNED_CERTIFICATE_TIMESTAMPS_CHECKED

// in net/log/net_log_event_type_list.h

-base::Value* NetLogSignedCertificateTimestampCallback(

+scoped_ptr<base::Value> NetLogSignedCertificateTimestampCallback(

const ct::CTVerifyResult* ct_result,

NetLogCaptureMode capture_mode);

@@ -25,7 +25,7 @@ base::Value* NetLogSignedCertificateTimestampCallback(

// in the NetLog.

// See the documentation for SIGNED_CERTIFICATE_TIMESTAMPS_RECEIVED

// in net/log/net_log_event_type_list.h

-base::Value* NetLogRawSignedCertificateTimestampCallback(

+scoped_ptr<base::Value> NetLogRawSignedCertificateTimestampCallback(

const std::string* embedded_scts,

const std::string* sct_list_from_ocsp,

const std::string* sct_list_from_tls_extension,