Change NetLog::ParametersCallback to return a scoped_ptr.

net/cert/multi_threaded_cert_verifier.cc

Index: net/cert/multi_threaded_cert_verifier.cc
diff --git a/net/cert/multi_threaded_cert_verifier.cc b/net/cert/multi_threaded_cert_verifier.cc
index 1bfb373b4698bea9c31ecdf9309c55cfa059390d..05b3dcd105224e906cbfe13c2ea53996082db655 100644
--- a/net/cert/multi_threaded_cert_verifier.cc
+++ b/net/cert/multi_threaded_cert_verifier.cc
@@ -81,9 +81,10 @@ const unsigned kMaxCacheEntries = 256;
 // The number of seconds to cache entries.
 const unsigned kTTLSecs = 1800;  // 30 minutes.
 
-base::Value* CertVerifyResultCallback(const CertVerifyResult& verify_result,
-                                      NetLogCaptureMode capture_mode) {
-  base::DictionaryValue* results = new base::DictionaryValue();
+scoped_ptr<base::Value> CertVerifyResultCallback(
+    const CertVerifyResult& verify_result,
+    NetLogCaptureMode capture_mode) {
+  scoped_ptr<base::DictionaryValue> results(new base::DictionaryValue());
   results->SetBoolean("has_md5", verify_result.has_md5);
   results->SetBoolean("has_md2", verify_result.has_md2);
   results->SetBoolean("has_md4", verify_result.has_md4);
@@ -98,16 +99,16 @@ base::Value* CertVerifyResultCallback(const CertVerifyResult& verify_result,
                NetLogX509CertificateCallback(verify_result.verified_cert.get(),
                                              capture_mode));
 
-  base::ListValue* hashes = new base::ListValue();
+  scoped_ptr<base::ListValue> hashes(new base::ListValue());
   for (std::vector<HashValue>::const_iterator it =
            verify_result.public_key_hashes.begin();
        it != verify_result.public_key_hashes.end();
        ++it) {
     hashes->AppendString(it->ToString());
   }
-  results->Set("public_key_hashes", hashes);
+  results->Set("public_key_hashes", hashes.Pass());

[eroman, 2015/05/21 03:37:42]

oh is this new?

[Evan Stade, 2015/05/21 15:30:42]

it didn't always exist but I don't think it's particularly new at this point

 
-  return results;
+  return results.Pass();
 }
 
 }  // namespace