Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: extensions/browser/api/web_request/web_request_api_helpers.cc

Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_api_helpers.cc
diff --git a/extensions/browser/api/web_request/web_request_api_helpers.cc b/extensions/browser/api/web_request/web_request_api_helpers.cc
index 73a8dd8fbf1236eab3ed2238bc2473bb7ba54590..7cc70350481856bf509d8071449c0c5a507b1cc4 100644
--- a/extensions/browser/api/web_request/web_request_api_helpers.cc
+++ b/extensions/browser/api/web_request/web_request_api_helpers.cc
@@ -218,9 +218,10 @@ net::NetLog::ParametersCallback CreateNetLogExtensionIdCallback(
// Creates NetLog parameters to indicate that an extension modified a request.
// Caller takes ownership of returned value.
eroman 2015/05/21 03:37:42 Delete this
-base::Value* NetLogModificationCallback(const EventResponseDelta* delta,
- net::NetLogCaptureMode capture_mode) {
- base::DictionaryValue* dict = new base::DictionaryValue();
+scoped_ptr<base::Value> NetLogModificationCallback(
+ const EventResponseDelta* delta,
+ net::NetLogCaptureMode capture_mode) {
+ scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetString("extension_id", delta->extension_id);
base::ListValue* modified_headers = new base::ListValue();
@@ -240,7 +241,7 @@ base::Value* NetLogModificationCallback(const EventResponseDelta* delta,
deleted_headers->Append(new base::StringValue(*key));
}
dict->Set("deleted_headers", deleted_headers);
- return dict;
+ return dict.Pass();
}
bool InDecreasingExtensionInstallationTimeOrder(

Powered by Google App Engine
This is Rietveld 408576698