Change NetLog::ParametersCallback to return a scoped_ptr.

extensions/browser/api/web_request/web_request_api_helpers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/web_request/web_request_api_helpers.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/bind.h"
@@ skipping 199 matching lines @@
 
 // Creates a NetLog callback the returns a Value with the ID of the extension
 // that caused an event.  |delta| must remain valid for the lifetime of the
 // callback.
 net::NetLog::ParametersCallback CreateNetLogExtensionIdCallback(
     const EventResponseDelta* delta) {
   return net::NetLog::StringCallback("extension_id", &delta->extension_id);
 }
 
 // Creates NetLog parameters to indicate that an extension modified a request.
 // Caller takes ownership of returned value.

[eroman, 2015/05/21 03:37:42]

Delete this

-base::Value* NetLogModificationCallback(const EventResponseDelta* delta,
-                                        net::NetLogCaptureMode capture_mode) {
-  base::DictionaryValue* dict = new base::DictionaryValue();
+scoped_ptr<base::Value> NetLogModificationCallback(
+    const EventResponseDelta* delta,
+    net::NetLogCaptureMode capture_mode) {
+  scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
   dict->SetString("extension_id", delta->extension_id);
 
   base::ListValue* modified_headers = new base::ListValue();
   net::HttpRequestHeaders::Iterator modification(
       delta->modified_request_headers);
   while (modification.GetNext()) {
     std::string line = modification.name() + ": " + modification.value();
     modified_headers->Append(new base::StringValue(line));
   }
   dict->Set("modified_headers", modified_headers);
 
   base::ListValue* deleted_headers = new base::ListValue();
   for (std::vector<std::string>::const_iterator key =
            delta->deleted_request_headers.begin();
        key != delta->deleted_request_headers.end();
        ++key) {
     deleted_headers->Append(new base::StringValue(*key));
   }
   dict->Set("deleted_headers", deleted_headers);
-  return dict;
+  return dict.Pass();
 }
 
 bool InDecreasingExtensionInstallationTimeOrder(
     const linked_ptr<EventResponseDelta>& a,
     const linked_ptr<EventResponseDelta>& b) {
   return a->extension_install_time > b->extension_install_time;
 }
 
 base::ListValue* StringToCharList(const std::string& s) {
   base::ListValue* result = new base::ListValue;
@@ skipping 1025 matching lines @@
       std::find(kResourceTypeStrings,
                 kResourceTypeStrings + kResourceTypeStringsLength,
                 type_str);
   if (iter == (kResourceTypeStrings + kResourceTypeStringsLength))
     return false;
   *type = kResourceTypeValues[iter - kResourceTypeStrings];
   return true;
 }
 
 }  // namespace extension_web_request_api_helpers