Open bookmark in new background tab at Ctrl+Click but not closing menu

This patch introduces new API ShouldExecuteCommandWithoutClosingMenu() in views::MenuDelegate for opening bookmark in background tab by Ctrl+Click.

BUG=75472
TEST=On folder menu in bookmark bar, Ctrl+Click bookmark menu items

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172517

[yosin_UTC9, 2012-12-11 04:32:14]

Hi Scott,
Could you review this patch?
Thanks in advance.

[sky, 2012-12-11 15:59:43]

LGTM

https://codereview.chromium.org/11485022/diff/1/chrome/browser/ui/views/bookm...
File chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h (right):

https://codereview.chromium.org/11485022/diff/1/chrome/browser/ui/views/bookm...
chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h:84: int id,
const ui::Event& e) OVERRIDE;
when you wrap each param on its own line.

https://codereview.chromium.org/11485022/diff/1/ui/views/controls/menu/menu_d...
File ui/views/controls/menu/menu_delegate.h (right):

https://codereview.chromium.org/11485022/diff/1/ui/views/controls/menu/menu_d...
ui/views/controls/menu/menu_delegate.h:115: // Returns true if command specified
by |id| should execute on event |e|
Returns true if ExecuteCommand() should be invoked while leaving the menu open.
Default implementation returns true.

[sky, 2012-12-11 16:34:16]

Also, fix BUG= and TEST= in the description, you have the wrong bug number.

[yosin_UTC9, 2012-12-12 01:39:39]

Thanks for quick response.
I updated the patch following reviewer's comments.

https://codereview.chromium.org/11485022/diff/1/chrome/browser/ui/views/bookm...
File chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h (right):

https://codereview.chromium.org/11485022/diff/1/chrome/browser/ui/views/bookm...
chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h:84: int id,
const ui::Event& e) OVERRIDE;
On 2012/12/11 15:59:43, sky wrote:
> when you wrap each param on its own line.

Done.

https://codereview.chromium.org/11485022/diff/1/ui/views/controls/menu/menu_d...
File ui/views/controls/menu/menu_delegate.h (right):

https://codereview.chromium.org/11485022/diff/1/ui/views/controls/menu/menu_d...
ui/views/controls/menu/menu_delegate.h:115: // Returns true if command specified
by |id| should execute on event |e|
On 2012/12/11 15:59:43, sky wrote:
> Returns true if ExecuteCommand() should be invoked while leaving the menu
open.
> Default implementation returns true.

Done.

[commit-bot: I haz the power, 2012-12-12 01:40:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/11485022/7001

[commit-bot: I haz the power, 2012-12-12 04:05:44]

Change committed as 172517