Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h

Issue 11485022: Open bookmark in new background tab at Ctrl+Click but not closing menu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 2012-12-12T10:27 Changes for review comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 // Sets the page navigator. 73 // Sets the page navigator.
74 void SetPageNavigator(content::PageNavigator* navigator); 74 void SetPageNavigator(content::PageNavigator* navigator);
75 75
76 void set_observer(Observer* observer) { observer_ = observer; } 76 void set_observer(Observer* observer) { observer_ = observer; }
77 77
78 // MenuDelegate methods. 78 // MenuDelegate methods.
79 virtual string16 GetTooltipText(int id, const gfx::Point& p) const OVERRIDE; 79 virtual string16 GetTooltipText(int id, const gfx::Point& p) const OVERRIDE;
80 virtual bool IsTriggerableEvent(views::MenuItemView* view, 80 virtual bool IsTriggerableEvent(views::MenuItemView* view,
81 const ui::Event& e) OVERRIDE; 81 const ui::Event& e) OVERRIDE;
82 virtual void ExecuteCommand(int id, int mouse_event_flags) OVERRIDE; 82 virtual void ExecuteCommand(int id, int mouse_event_flags) OVERRIDE;
83 virtual bool ShouldExecuteCommandWithoutClosingMenu(
84 int id,
85 const ui::Event& e) OVERRIDE;
83 virtual bool GetDropFormats( 86 virtual bool GetDropFormats(
84 views::MenuItemView* menu, 87 views::MenuItemView* menu,
85 int* formats, 88 int* formats,
86 std::set<ui::OSExchangeData::CustomFormat>* custom_formats) OVERRIDE; 89 std::set<ui::OSExchangeData::CustomFormat>* custom_formats) OVERRIDE;
87 virtual bool AreDropTypesRequired(views::MenuItemView* menu) OVERRIDE; 90 virtual bool AreDropTypesRequired(views::MenuItemView* menu) OVERRIDE;
88 virtual bool CanDrop(views::MenuItemView* menu, 91 virtual bool CanDrop(views::MenuItemView* menu,
89 const ui::OSExchangeData& data) OVERRIDE; 92 const ui::OSExchangeData& data) OVERRIDE;
90 virtual int GetDropOperation(views::MenuItemView* item, 93 virtual int GetDropOperation(views::MenuItemView* item,
91 const ui::DropTargetEvent& event, 94 const ui::DropTargetEvent& event,
92 DropPosition* position) OVERRIDE; 95 DropPosition* position) OVERRIDE;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 bool for_drop_; 137 bool for_drop_;
135 138
136 // The bookmark bar. This is only non-null if we're showing a menu item 139 // The bookmark bar. This is only non-null if we're showing a menu item
137 // for a folder on the bookmark bar and not for drop. 140 // for a folder on the bookmark bar and not for drop.
138 BookmarkBarView* bookmark_bar_; 141 BookmarkBarView* bookmark_bar_;
139 142
140 DISALLOW_COPY_AND_ASSIGN(BookmarkMenuController); 143 DISALLOW_COPY_AND_ASSIGN(BookmarkMenuController);
141 }; 144 };
142 145
143 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_ 146 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698