Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

Issue 11485022: Open bookmark in new background tab at Ctrl+Click but not closing menu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 2012-12-12T10:27 Changes for review comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
index a7cea645737d9ebff105d31ccae54fcccbe3f09e..79b87d8889b14487b49ccad600cc295f8c5d00dc 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
@@ -135,6 +135,12 @@ void BookmarkMenuDelegate::ExecuteCommand(int id, int mouse_event_flags) {
bookmark_utils::RecordBookmarkLaunch(location_);
}
+bool BookmarkMenuDelegate::ShouldExecuteCommandWithoutClosingMenu(
+ int id, const ui::Event& event) {
+ return (event.flags() & ui::EF_LEFT_MOUSE_BUTTON) &&
+ chrome::DispositionFromEventFlags(event.flags()) == NEW_BACKGROUND_TAB;
+}
+
bool BookmarkMenuDelegate::GetDropFormats(
MenuItemView* menu,
int* formats,
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h ('k') | ui/views/controls/menu/menu_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698