Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1557)

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.h

Issue 1148383012: Oilpan: prefer eager finalization over prefinalizers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: expand&improve comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webmidi/MIDIAccessInitializer.h
diff --git a/Source/modules/webmidi/MIDIAccessInitializer.h b/Source/modules/webmidi/MIDIAccessInitializer.h
index 6221b617fd4b3644fff0e2e320b7339d6a8bf5c6..8824e76de760ea218ce9121725e403376859da66 100644
--- a/Source/modules/webmidi/MIDIAccessInitializer.h
+++ b/Source/modules/webmidi/MIDIAccessInitializer.h
@@ -20,7 +20,6 @@ class MIDIOptions;
class ScriptState;
class MODULES_EXPORT MIDIAccessInitializer : public ScriptPromiseResolver, public MIDIAccessorClient {
- WILL_BE_USING_PRE_FINALIZER(MIDIAccessInitializer, dispose);
public:
struct PortDescriptor {
String id;
@@ -49,6 +48,10 @@ public:
~MIDIAccessInitializer() override;
+ // Eager finalization to allow dispose() operation access
+ // other (non eager) heap objects.
+ EAGERLY_FINALIZE();
+
// MIDIAccessorClient
void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, MIDIAccessor::MIDIPortState) override;
void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, MIDIAccessor::MIDIPortState) override;
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerRegistration.cpp ('k') | Source/modules/webmidi/MIDIAccessInitializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698