Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.cpp

Issue 1148383012: Oilpan: prefer eager finalization over prefinalizers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: expand&improve comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webmidi/MIDIAccessInitializer.h ('k') | Source/platform/speech/PlatformSpeechSynthesizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccessInitializer.cpp
diff --git a/Source/modules/webmidi/MIDIAccessInitializer.cpp b/Source/modules/webmidi/MIDIAccessInitializer.cpp
index ffe821d2d8e286f176cd2037eac8c2b1b815c83d..83407f0ecce013f48cf225a934ad380bfbb38871 100644
--- a/Source/modules/webmidi/MIDIAccessInitializer.cpp
+++ b/Source/modules/webmidi/MIDIAccessInitializer.cpp
@@ -26,24 +26,13 @@ MIDIAccessInitializer::MIDIAccessInitializer(ScriptState* scriptState, const MID
, m_hasBeenDisposed(false)
, m_sysexPermissionResolved(false)
{
-#if ENABLE(OILPAN)
-#if ENABLE(ASSERT)
- // A prefinalizer has already been registered for ScriptPromiseResolver;
- // remove it and register a combined one as the infrastructure doesn't
- // support multiple prefinalizers for an object.
- ThreadState::current()->unregisterPreFinalizer(*static_cast<ScriptPromiseResolver*>(this));
-#endif
- ThreadState::current()->registerPreFinalizer(*this);
-#endif
if (options.hasSysex())
m_requestSysex = options.sysex();
}
MIDIAccessInitializer::~MIDIAccessInitializer()
{
-#if !ENABLE(OILPAN)
dispose();
-#endif
}
void MIDIAccessInitializer::contextDestroyed()
@@ -69,9 +58,6 @@ void MIDIAccessInitializer::dispose()
}
m_hasBeenDisposed = true;
-#if ENABLE(OILPAN) && ENABLE(ASSERT)
- ScriptPromiseResolver::dispose();
-#endif
}
ScriptPromise MIDIAccessInitializer::start()
« no previous file with comments | « Source/modules/webmidi/MIDIAccessInitializer.h ('k') | Source/platform/speech/PlatformSpeechSynthesizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698