Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

Issue 1148383012: Oilpan: prefer eager finalization over prefinalizers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: expand&improve comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp b/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
index 7209b588a788b4c4a81e320f33b6cb44df54de5a..1f7f2a6e4b6e28e0db7241f71704b52d93ae3a31 100644
--- a/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
@@ -132,7 +132,6 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(ExecutionContext* execution
, m_stopped(false)
{
ASSERT(m_outerRegistration);
- ThreadState::current()->registerPreFinalizer(*this);
if (!executionContext)
return;
@@ -143,13 +142,6 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(ExecutionContext* execution
ServiceWorkerRegistration::~ServiceWorkerRegistration()
{
- ASSERT(!m_outerRegistration);
-}
-
-void ServiceWorkerRegistration::dispose()
-{
- // See ServiceWorker::dispose() comment why this explicit dispose() action is needed.
- m_outerRegistration.clear();
}
DEFINE_TRACE(ServiceWorkerRegistration)
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerRegistration.h ('k') | Source/modules/webmidi/MIDIAccessInitializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698