DescriptionRemove dependency on resources from installer_util
chrome/installer/util used to depend on chrome:resources but was apparently never used. This causes a problem because chrome_watcher.dll depends on installer_util, and chrome:resources depends on the omnibox mojo target. To get this dependency "right" we would have to link all of mojo system into chrome_watcher.dll. It is properly dead-code stripped (I checked) but this still seems undesirable.
I removed the dependency and also made //chrome/installer/* "gn check" clean. There were some other unnecessary deps and header file uses.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Committed: https://crrev.com/74a2a34fce36365a04a50f6b781187b17ae71b73
Cr-Commit-Position: refs/heads/master@{#330895}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : merge #Patch Set 4 : ix non-Windows gn check #
Total comments: 2
Messages
Total messages: 20 (8 generated)
|