Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1148173002: Remove dependency on resources from installer_util (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, grt+watch_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on resources from installer_util chrome/installer/util used to depend on chrome:resources but was apparently never used. This causes a problem because chrome_watcher.dll depends on installer_util, and chrome:resources depends on the omnibox mojo target. To get this dependency "right" we would have to link all of mojo system into chrome_watcher.dll. It is properly dead-code stripped (I checked) but this still seems undesirable. I removed the dependency and also made //chrome/installer/* "gn check" clean. There were some other unnecessary deps and header file uses. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/74a2a34fce36365a04a50f6b781187b17ae71b73 Cr-Commit-Position: refs/heads/master@{#330895}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge #

Patch Set 4 : ix non-Windows gn check #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 2 4 chunks +14 lines, -6 lines 2 comments Download
M chrome/installer/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/util/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/installer/util/auto_launch_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/user_experiment.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
brettw
5 years, 7 months ago (2015-05-20 18:00:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148173002/20001
5 years, 7 months ago (2015-05-20 18:18:19 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_dbg on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/451) mac_chromium_gn_rel on ...
5 years, 7 months ago (2015-05-20 18:23:38 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148173002/40001
5 years, 7 months ago (2015-05-20 19:24:34 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/90116)
5 years, 7 months ago (2015-05-20 19:53:23 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148173002/60001
5 years, 7 months ago (2015-05-20 20:13:30 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 21:44:14 UTC) #14
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/1148173002/diff/60001/chrome/common/BUILD.gn File chrome/common/BUILD.gn (right): https://codereview.chromium.org/1148173002/diff/60001/chrome/common/BUILD.gn#newcode49 chrome/common/BUILD.gn:49: ] did you mean to change this in ...
5 years, 7 months ago (2015-05-20 23:33:50 UTC) #15
brettw
https://codereview.chromium.org/1148173002/diff/60001/chrome/common/BUILD.gn File chrome/common/BUILD.gn (right): https://codereview.chromium.org/1148173002/diff/60001/chrome/common/BUILD.gn#newcode49 chrome/common/BUILD.gn:49: ] On 2015/05/20 23:33:50, cpu wrote: > did you ...
5 years, 7 months ago (2015-05-21 04:38:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148173002/60001
5 years, 7 months ago (2015-05-21 04:39:13 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-21 04:43:49 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:44:54 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/74a2a34fce36365a04a50f6b781187b17ae71b73
Cr-Commit-Position: refs/heads/master@{#330895}

Powered by Google App Engine
This is Rietveld 408576698