Chromium Code Reviews| Index: chrome/common/BUILD.gn |
| diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn |
| index b38817572a02cb4a72c8dc790216f44ea4bcad16..751349dd665205e7cc5f4b7cd5e97bf364d25ea9 100644 |
| --- a/chrome/common/BUILD.gn |
| +++ b/chrome/common/BUILD.gn |
| @@ -42,6 +42,11 @@ static_library("common") { |
| configs += [ "//build/config/compiler:wexit_time_destructors" ] |
| + public_deps = [ |
| + "//chrome/common:constants", |
| + "//chrome/common/net", |
| + "//chrome/common/safe_browsing:proto", |
| + ] |
|
cpu_(ooo_6.6-7.5)
2015/05/20 23:33:50
did you mean to change this in this CL?
brettw
2015/05/21 04:38:10
Yes, this is necessary for the "gn check" to pass
|
| deps = [ |
| ":version", |
| "//base:base", |
| @@ -51,9 +56,6 @@ static_library("common") { |
| "//chrome:resources", |
| "//chrome:strings", |
| "//chrome/app/theme:theme_resources", |
| - "//chrome/common:constants", |
| - "//chrome/common/net", |
| - "//chrome/common/safe_browsing:proto", |
| "//chrome/installer/util", |
| "//components/cloud_devices/common", |
| "//components/component_updater", |
| @@ -97,9 +99,7 @@ static_library("common") { |
| "//third_party/re2", |
| "//third_party/widevine/cdm:version_h", |
| ] |
| - public_deps = [ |
| - "//third_party/mojo/src/mojo/public/cpp/bindings", |
| - ] |
| + public_deps += [ "//third_party/mojo/src/mojo/public/cpp/bindings" ] |
| } |
| if (enable_extensions) { |
| @@ -247,6 +247,14 @@ static_library("common") { |
| } |
| } |
| +# This target allows other targets to depend on result_codes.h which is a |
| +# header-only dependency, without bringing in all of content. |
| +source_set("result_codes") { |
| + sources = [ |
| + "chrome_result_codes.h", |
| + ] |
| +} |
| + |
| import("//chrome/version.gni") |
| process_version("version") { |
| visibility = [ ":common" ] |