Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5411)

Unified Diff: chrome/common/BUILD.gn

Issue 1148173002: Remove dependency on resources from installer_util (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ix non-Windows gn check Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_installer_util.gypi ('k') | chrome/installer/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index b38817572a02cb4a72c8dc790216f44ea4bcad16..751349dd665205e7cc5f4b7cd5e97bf364d25ea9 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -42,6 +42,11 @@ static_library("common") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
+ public_deps = [
+ "//chrome/common:constants",
+ "//chrome/common/net",
+ "//chrome/common/safe_browsing:proto",
+ ]
cpu_(ooo_6.6-7.5) 2015/05/20 23:33:50 did you mean to change this in this CL?
brettw 2015/05/21 04:38:10 Yes, this is necessary for the "gn check" to pass
deps = [
":version",
"//base:base",
@@ -51,9 +56,6 @@ static_library("common") {
"//chrome:resources",
"//chrome:strings",
"//chrome/app/theme:theme_resources",
- "//chrome/common:constants",
- "//chrome/common/net",
- "//chrome/common/safe_browsing:proto",
"//chrome/installer/util",
"//components/cloud_devices/common",
"//components/component_updater",
@@ -97,9 +99,7 @@ static_library("common") {
"//third_party/re2",
"//third_party/widevine/cdm:version_h",
]
- public_deps = [
- "//third_party/mojo/src/mojo/public/cpp/bindings",
- ]
+ public_deps += [ "//third_party/mojo/src/mojo/public/cpp/bindings" ]
}
if (enable_extensions) {
@@ -247,6 +247,14 @@ static_library("common") {
}
}
+# This target allows other targets to depend on result_codes.h which is a
+# header-only dependency, without bringing in all of content.
+source_set("result_codes") {
+ sources = [
+ "chrome_result_codes.h",
+ ]
+}
+
import("//chrome/version.gni")
process_version("version") {
visibility = [ ":common" ]
« no previous file with comments | « chrome/chrome_installer_util.gypi ('k') | chrome/installer/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698