Remove dependency on resources from installer_util

chrome/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//tools/grit/grit_rule.gni")
 import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni")
 
 gypi_values = exec_script("//build/gypi_to_gn.py",
                           [ rebase_path("../chrome_common.gypi") ],
                           "scope",
@@ skipping 24 matching lines @@
   }
 }
 
 # GYP version: chrome/chrome_common.gyp:common
 static_library("common") {
   sources = rebase_path(gypi_values.chrome_common_sources, ".", "//chrome")
   defines = []
 
   configs += [ "//build/config/compiler:wexit_time_destructors" ]
 
+  public_deps = [
+    "//chrome/common:constants",
+    "//chrome/common/net",
+    "//chrome/common/safe_browsing:proto",
+  ]

[cpu_(ooo_6.6-7.5), 2015/05/20 23:33:50]

did you mean to change this in this CL?

[brettw, 2015/05/21 04:38:10]

Yes, this is necessary for the "gn check" to pass since it allows the installer
targets that depend on it to use these targets.

   deps = [
     ":version",
     "//base:base",
     "//base:i18n",
     "//base:prefs",
     "//base:base_static",
     "//chrome:resources",
     "//chrome:strings",
     "//chrome/app/theme:theme_resources",
-    "//chrome/common:constants",
-    "//chrome/common/net",
-    "//chrome/common/safe_browsing:proto",
     "//chrome/installer/util",
     "//components/cloud_devices/common",
     "//components/component_updater",
     "//components/content_settings/core/common",
     "//components/favicon_base",
     "//components/json_schema",
     "//components/metrics",
     "//components/policy:policy_component_common",
     "//components/translate/core/common",
     "//components/variations",
@@ skipping 23 matching lines @@
       "//components/autofill/content/common",
       "//components/autofill/core/common",
       "//components/password_manager/content/common",
       "//components/password_manager/core/common",
       "//components/signin/core/common",
       "//components/translate/content/common",
       "//ipc",
       "//third_party/re2",
       "//third_party/widevine/cdm:version_h",
     ]
-    public_deps = [
-      "//third_party/mojo/src/mojo/public/cpp/bindings",
-    ]
+    public_deps += [ "//third_party/mojo/src/mojo/public/cpp/bindings" ]
   }
 
   if (enable_extensions) {
     sources += rebase_path(gypi_values.chrome_common_extensions_sources,
                            ".",
                            "//chrome")
     deps += [
       "//device/usb",
       "//chrome/common/extensions/api",
       "//extensions/common",
@@ skipping 127 matching lines @@
     deps += [ "//components/policy" ]
   }
 
   if (safe_browsing_mode == 1) {
     sources += rebase_path(gypi_values.chrome_common_full_safe_browsing_sources,
                            ".",
                            "//chrome")
   }
 }
 
+# This target allows other targets to depend on result_codes.h which is a
+# header-only dependency, without bringing in all of content.
+source_set("result_codes") {
+  sources = [
+    "chrome_result_codes.h",
+  ]
+}
+
 import("//chrome/version.gni")
 process_version("version") {
   visibility = [ ":common" ]
   template_file = "chrome_version_info_values.h.version"
   output = "$target_gen_dir/chrome_version_info_values.h"
 }
 
 process_version("make_chrome_version") {
   template_file = "chrome_version.cc.version"
   output = "$target_gen_dir/chrome_version.cc"
@@ skipping 84 matching lines @@
     ":constants",
     "//base",
   ]
 }
 
 mojom("mojo_bindings") {
   sources = [
     "resource_usage_reporter.mojom",
   ]
 }