Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1148093002: Skip presubmits when doing --download-data-only. (Closed)

Created:
5 years, 7 months ago by bradn
Modified:
5 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip presubmits when doing --download-data-only. BUG=v8:4124 LOG=N R=machenbach@chromium.org TEST=None Committed: https://crrev.com/3cc9c0e36f5ccd483e7611b0f98d1ff390b7628a Cr-Commit-Position: refs/heads/master@{#28527}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/run-tests.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
bradn
5 years, 7 months ago (2015-05-20 15:09:28 UTC) #1
Michael Achenbach
lgtm
5 years, 7 months ago (2015-05-20 16:58:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148093002/20001
5 years, 7 months ago (2015-05-20 16:58:56 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 17:06:20 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:06:35 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cc9c0e36f5ccd483e7611b0f98d1ff390b7628a
Cr-Commit-Position: refs/heads/master@{#28527}

Powered by Google App Engine
This is Rietveld 408576698