Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/run-tests.py

Issue 1148093002: Skip presubmits when doing --download-data-only. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index 3186b0b2fc08b13595681f6003a2bff6bd2ef0d8..274bb18ac62227573d98ab705eaacb805705cd36 100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -343,6 +343,8 @@ def ProcessOptions(options):
# Buildbots run presubmit tests as a separate step.
options.no_presubmit = True
options.no_network = True
+ if options.download_data_only:
+ options.no_presubmit = True
if options.command_prefix:
print("Specifying --command-prefix disables network distribution, "
"running tests locally.")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698