Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: tools/run-tests.py

Issue 1148093002: Skip presubmits when doing --download-data-only. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 # predefined arch_and_mode since it is more expressive than arch and mode. 336 # predefined arch_and_mode since it is more expressive than arch and mode.
337 if not options.arch_and_mode: 337 if not options.arch_and_mode:
338 options.arch_and_mode = itertools.product(options.arch, options.mode) 338 options.arch_and_mode = itertools.product(options.arch, options.mode)
339 339
340 # Special processing of other options, sorted alphabetically. 340 # Special processing of other options, sorted alphabetically.
341 341
342 if options.buildbot: 342 if options.buildbot:
343 # Buildbots run presubmit tests as a separate step. 343 # Buildbots run presubmit tests as a separate step.
344 options.no_presubmit = True 344 options.no_presubmit = True
345 options.no_network = True 345 options.no_network = True
346 if options.download_data_only:
347 options.no_presubmit = True
346 if options.command_prefix: 348 if options.command_prefix:
347 print("Specifying --command-prefix disables network distribution, " 349 print("Specifying --command-prefix disables network distribution, "
348 "running tests locally.") 350 "running tests locally.")
349 options.no_network = True 351 options.no_network = True
350 options.command_prefix = shlex.split(options.command_prefix) 352 options.command_prefix = shlex.split(options.command_prefix)
351 options.extra_flags = shlex.split(options.extra_flags) 353 options.extra_flags = shlex.split(options.extra_flags)
352 354
353 if options.gc_stress: 355 if options.gc_stress:
354 options.extra_flags += GC_STRESS_FLAGS 356 options.extra_flags += GC_STRESS_FLAGS
355 357
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 exit_code = runner.Run(options.j) 649 exit_code = runner.Run(options.j)
648 overall_duration = time.time() - start_time 650 overall_duration = time.time() - start_time
649 651
650 if options.time: 652 if options.time:
651 verbose.PrintTestDurations(suites, overall_duration) 653 verbose.PrintTestDurations(suites, overall_duration)
652 return exit_code 654 return exit_code
653 655
654 656
655 if __name__ == "__main__": 657 if __name__ == "__main__":
656 sys.exit(Main()) 658 sys.exit(Main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698